fix(twap): hide learn more link #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
reviewed
Jul 7, 2023
| </span> | ||
| {showLink && ( | ||
| <span> | ||
| Learn more about <ExternalLink href={buttonLink}>{orderType} orders ↗</ExternalLink> |
There was a problem hiding this comment.
why not making buttonLink optional param instead?
There was a problem hiding this comment.
this way, we just need to not specify the URL until is available
There was a problem hiding this comment.
Good suggestion, will update.
elena-zh
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Changes LGTM besides the question I mentioned in #2803 (review)
And maybe we should remove 'new' from the Limit orders Unlock screen?
|
The new doesn't bother me personally, but maybe you are right. Fine to remove too, no preference |
anxolin
approved these changes
Jul 10, 2023
alfetopito
approved these changes
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hides learn more text from Unlock screen on advanced orders
Source https://cowservices.slack.com/archives/C0361CDG8GP/p1688740674594089
To test